Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add test to ensure mocks are up-to-date #437

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

Dimitar-St
Copy link
Contributor

Linked with this issue #334. Added workflow for keeping mocks up to date.

check-latest: true
- uses: bufbuild/buf-setup-action@v1.23.1
- shell: bash
run: scripts/protobuf_codegen.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this, there is no protobuf in this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, now it's removed.

@@ -0,0 +1,24 @@
name: Auto-Generated Code Checker
on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change...can you make this on: section match:

on:
push:
branches:
- main
pull_request:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Really foolish mistakes, I apologize!

Copy link
Contributor

@patrick-ogrady patrick-ogrady Sep 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Running tests now.

@Dimitar-St Dimitar-St marked this pull request as ready for review September 5, 2023 19:43
@patrick-ogrady patrick-ogrady linked an issue Sep 5, 2023 that may be closed by this pull request
@patrick-ogrady
Copy link
Contributor

Going to fix after merging

@patrick-ogrady patrick-ogrady merged commit 47eac2d into ava-labs:main Sep 5, 2023
14 of 15 checks passed
@Dimitar-St
Copy link
Contributor Author

Going to fix after merging

Is there a specific reason why it's failing with permission denied ?

@patrick-ogrady
Copy link
Contributor

Going to fix after merging

Is there a specific reason why it's failing with permission denied ?

Yeah, you didn't chmod the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] Add test to ensure mocks are up-to-date
2 participants