Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chain] Remove State Access from Auth #669

Merged
merged 23 commits into from
Jan 20, 2024
Merged

[chain] Remove State Access from Auth #669

merged 23 commits into from
Jan 20, 2024

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jan 10, 2024

Resolves: #619

Changes

  • Remove Auth access to state until actually needed (when programs are mature) and can be re-added safely (unbounded state access is a DoS as validity can change just before inclusion in ways not related to being out-of-funds, which greatly impacts decoupled verification) -> This still allows ACL but at the Action level rather than abstractly via Auth
  • Remove Auth access to Action
  • Remove Auth.Verify
  • Unify shared interfaces between Action, Actor, Auth in Object
  • Update README

Future Work

  • Add access to time-delayed/versioned state (to ensure a change to state accessed during a validity check can be observed long before a transaction is sequenced)
  • Allow Actor to send a non-native token to pay fees (would require integrated tokens in VM)

@patrick-ogrady patrick-ogrady marked this pull request as draft January 10, 2024 15:20
@patrick-ogrady patrick-ogrady changed the title [chain] Separate Actor and Sponsor [chain] Extract Actor and Sponsor from Auth Jan 10, 2024
@patrick-ogrady patrick-ogrady changed the title [chain] Extract Actor and Sponsor from Auth [chain] Replace Auth with Actor and Sponsor Jan 10, 2024
@patrick-ogrady patrick-ogrady self-assigned this Jan 20, 2024
@patrick-ogrady patrick-ogrady changed the title [chain] Replace Auth with Actor and Sponsor [chain] Remove State Access from Auth Jan 20, 2024
@patrick-ogrady patrick-ogrady marked this pull request as ready for review January 20, 2024 22:39
@patrick-ogrady patrick-ogrady merged commit e3da174 into main Jan 20, 2024
22 checks passed
@patrick-ogrady patrick-ogrady deleted the actor-auth branch January 20, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[auth] Separate Actor and Sponsor into Separate Auth Objects + Remove Auth from Action
1 participant