Refactor token source contracts #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917 and
bernard-avalabs
as code owners
Refactor token source contracts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
contracts/src/CrossChainApplications/examples/NativeTokenBridge/ITokenSource.sol
Outdated
Show resolved
Hide resolved
| */ | ||
| function _unlockTokens(address recipient, uint256 amount) private { | ||
| function _unlockTokens(address recipient, uint256 amount) internal override { |
There was a problem hiding this comment.
Calling out that the visibility of _unlockTokens and _handleBurnTokens is changing from private to internal. This should be okay, given that we don't expect anything to inherit from these contracts (and if someone does, that's on them), but it is a minor change.
| @@ -0,0 +1,96 @@ | |||
| // (c) 2024, Ava Labs, Inc. All rights reserved. | |||
There was a problem hiding this comment.
we should update the other licenses to 2024 before launch
There was a problem hiding this comment.
I do not think we should update any old copyright dates. This SO thread aligns with my understanding of copyright law https://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated
contracts/src/CrossChainApplications/examples/NativeTokenBridge/TokenSource.sol
Show resolved
Hide resolved
contracts/src/CrossChainApplications/examples/NativeTokenBridge/TokenSource.sol
Outdated
Show resolved
Hide resolved
contracts/src/CrossChainApplications/examples/NativeTokenBridge/TokenSource.sol
Outdated
Show resolved
Hide resolved
geoff-vball
dismissed stale reviews from cam-schultz and michaelkaplan13
via
ffe08c3
…e/TokenSource.sol Co-authored-by: minghinmatthewlam <matthew.lam@avalabs.org> Signed-off-by: Geoff Stuart <geoff.vball@gmail.com>
cam-schultz
previously approved these changes
Jan 16, 2024
cam-schultz
previously approved these changes
Jan 16, 2024
michaelkaplan13
previously approved these changes
Jan 17, 2024
contracts/src/CrossChainApplications/examples/NativeTokenBridge/NativeTokenDestination.sol
Outdated
Show resolved
Hide resolved
minghinmatthewlam
previously approved these changes
Jan 17, 2024
…e/NativeTokenDestination.sol Co-authored-by: minghinmatthewlam <matthew.lam@avalabs.org> Signed-off-by: Geoff Stuart <geoff.vball@gmail.com>
geoff-vball
dismissed stale reviews from minghinmatthewlam, michaelkaplan13, and cam-schultz
via
f6fd719
geoff-vball
requested review from
cam-schultz,
michaelkaplan13 and
minghinmatthewlam
minghinmatthewlam
previously approved these changes
Jan 17, 2024
cam-schultz
previously approved these changes
Jan 17, 2024
geoff-vball
dismissed stale reviews from cam-schultz and minghinmatthewlam
via
67d1279
michaelkaplan13
approved these changes
Jan 17, 2024
minghinmatthewlam
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #219
How this works
Extracts common code from
ERC20TokenSourceandNativeTokenSourceinto an abstract contractTokenSource.How this was tested
Existing tests
How is this documented
N/A