Minor fixes to local network scripts #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/tweak-setup-scripts
branch
from
1f89034 to
4ac8bc9
Compare
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917 and
bernard-avalabs
as code owners
minghinmatthewlam
approved these changes
Feb 13, 2024
| # Set up the trap to catch the SIGINT signal (CTRL+C) | ||
| # Note that the output of the cleanup function defined in run_setup.sh does not appear if CTRL+C is used to kill this script, | ||
| # but the function does in fact run as expected. | ||
| trap cleanup SIGTERM | ||
| trap cleanup SIGINT | ||
| trap cleanup SIGTERM SIGINT |
There was a problem hiding this comment.
was the script hanging after CTRL+C? I thought that's what the trap was handling, and don't think ive had that issue previously
There was a problem hiding this comment.
No, it was hanging on line 64 if docker errored out. CTRL+C got it to exit, but you shouldn't have to in that situation.
michaelkaplan13
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes some minor issues in the local network scripts, including having one script hanging after exit.
How this works
How this was tested
Locally
How is this documented