Snyk upload fix #361
Snyk upload fix #361
Conversation
michaelkaplan13
requested review from
cam-schultz,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
| @@ -50,6 +50,6 @@ RUN apt-get update && \ | |||
| RUN pip3 install base58 | |||
|
|
|||
| # Install avalanche-cli | |||
| RUN curl -sSfL https://raw.githubusercontent.com/ava-labs/avalanche-cli/main/scripts/install.sh | sh -s -- -b /usr/local/bin v1.3.7 | |||
There was a problem hiding this comment.
Any issues running the docker images with the upgraded CLI version?
There was a problem hiding this comment.
Confirm it works with the new version now (needed to add a couple flags to make the command non-interactive).
Long term, we'll remove the Dockerfile set up all together in favor of the embedded Teleporter + AWM relayer support in the AvalancheCLI 🙌
|
Snyk is still failing on scanning the docker image because the latest |
Signed-off-by: cam-schultz <78878559+cam-schultz@users.noreply.github.com>
| echo "Creating new subnet A..." | ||
| avalanche subnet create subneta --force --genesis ./subnetGenesis_A.json --config ./docker/defaultNodeConfig.json --evm --vm-version $SUBNET_EVM_VERSION --log-level info --skip-update-check | ||
| avalanche subnet create subneta --force --genesis ./subnetGenesis_A.json --config ./docker/defaultNodeConfig.json --evm --vm-version $SUBNET_EVM_VERSION --log-level info --skip-update-check --teleporter=false --relayer=false |
There was a problem hiding this comment.
could we just use the cli to deploy teleporter/relayer at this point? I'd assume there would need additional effort to update the docker setup, so not worth right now
There was a problem hiding this comment.
Yep that's the plan in the near-ish future 👍
#361 (comment)
Why this should be merged
Fixes the snyk workflow
How this works
See github/codeql-action#2187 (comment)
How this was tested
CI
How is this documented
N/A