forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: vm.JumpTable
override
#30
Open
ARR4N
wants to merge
22
commits into
main
Choose a base branch
from
arr4n/jumptable-override
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested review from
a team,
darioush,
ceyonur and
michaelkaplan13
and removed request for
a team
September 17, 2024 20:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Allows for creation of unexported
vm.operation
s and their injection intovm.JumpTable
s through a registered hook.First step to full support of #22.
How this works
Introduces
vm.Hooks
that can be registered viavm.RegisterHooks()
. These are far simpler thanparams
hooks as they don't need payloads. Thevm.Hooks.OverrideJumpTable()
hook is used in bothNewEVMInterpreter()
andLookupInstructionSet()
to modify their respectiveJumpTable
s after creation. This couldn't be defined onparams.RulesHooks
due to a circular dependency.The
vm.OperationBuilder
factory is also introduced to allow creation of the otherwise unexportedoperation
type. I chose this pattern over a function because it makes arguments clearer at the usage site. To provide access to internal identifiers, the customOperationFunc
is an extension of the regularexecutionFunc
to also accept anOperationEnvironment
(similar to aPrecompileEnvironment
).How this was tested
Integration tests that demonstrate (a) honouring of the params hook signal; and (b) proper execution of a newly created
*operation
.