forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: precompilegen
Solidity interface -> stateful precompile
#72
Draft
ARR4N
wants to merge
23
commits into
main
Choose a base branch
from
arr4n/precompilegen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Note that this is not a full replacement for
ava-labs/subnet-evm/cmd/precompilegen
. The original conflates the general concept of stateful precompiles with Ava-specific functionality (e.g. implementation configuration, module registration, etc.) while this PR is purely a mechanism for creating precompiles that conform to Solidity interfaces. In addition to the benefits I outline below, there is a case for separation of concerns.The main benefits of this approach are that:
vm.PrecompiledContract
. Thesubnet-evm
generator leaves place for custom code to be inserted, making it impossible to update the boilerplate without overwriting customisation.How this works
Code generation is analogous to gRPC server stubs:
precompilegen
solc
ABI outputtype FooServer interface
type Contract interface
func RegisterFooServer(..., FooServer)
func New(Contract) vm.PrecompiledContract
becomes
which is used for the return values of
params.RulesHooks.PrecompileOverride
.Tip
See
libevm/precompilegen/testprecompile/generated.go
for output andlibevm/precompilegen/testprecompile/generated_test.go
for an example implementation.To-do
contract.UseGas() bool
equivalent onvm.PrecompileEnvironment
(refactor:PrecompileEnvironment.{,Use,Refund}Gas()
in lieu of args #73).payable
andview
/pure
implications.How this was tested
Integration test exercising Solidity-based test via a
simulated.Backend
.