Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take single predicate in VerifyPredicates #844

Closed
ceyonur opened this issue Sep 6, 2023 · 3 comments · Fixed by #960
Closed

Take single predicate in VerifyPredicates #844

ceyonur opened this issue Sep 6, 2023 · 3 comments · Fixed by #960
Assignees

Comments

@ceyonur
Copy link
Collaborator

ceyonur commented Sep 6, 2023

From: #823 (comment)

In the PR #823 we have changed the signature from
VerifyPredicate(predicateContext *PredicateContext, storageSlots []byte) error to VerifyPredicate(predicateContext *PredicateContext, predicates [][]byte) []byte in the latter we return bitsets as a result to CheckPredicates. We can investigate if we can keep a single predicate param in VerifyPredicate and return error then construct bitset in CheckPredicates instead.

@ceyonur
Copy link
Collaborator Author

ceyonur commented Oct 2, 2023

@aaronbuchwald could you check this out and close if not required anymore?

@aaronbuchwald
Copy link
Collaborator

I think this would be a good refactor and don't think we need to close this issue.

@ceyonur ceyonur self-assigned this Oct 16, 2023
@ceyonur
Copy link
Collaborator Author

ceyonur commented Oct 16, 2023

I can take a look

@ceyonur ceyonur moved this from Backlog 🗄️ to In Review 👀 in Platform Engineering Group Nov 13, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Platform Engineering Group Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Status: Backlog 🗄
Development

Successfully merging a pull request may close this issue.

2 participants