verify single predicate #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha-ctrl
reviewed
Oct 19, 2023
anusha-ctrl
reviewed
Oct 19, 2023
anusha-ctrl
approved these changes
Oct 20, 2023
Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
marun
reviewed
Nov 21, 2023
|
I put up another PR to add a comparison test between old code vs new to ensure they return same results: |
…evm into single-predicate-verify
marun
reviewed
Nov 27, 2023
marun
previously approved these changes
Nov 29, 2023
|
Nits: #1012 |
darioush
previously approved these changes
Dec 1, 2023
marun
previously approved these changes
Dec 1, 2023
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Co-authored-by: aaronbuchwald <aaron.buchwald56@gmail.com> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
…evm into single-predicate-verify
aaronbuchwald
previously approved these changes
Dec 4, 2023
marun
approved these changes
Dec 5, 2023
aaronbuchwald
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
VerifyPredicateis aPredicaterinterface function which can be implemented by precompiles to start using predicates and verify them. This means external developers are exposed to this interface. This PR simplifies returned type ofVerifyPredicateandpredicateBytesparam. It also cleans up/reduces multiple access list loops.Closes: #844
How this works
It moves bitset construction to the
CheckPredicatesfunction and changesVerifyPredicatesignature.How this was tested
Added UTs and existing tests should cover this.
I put up another PR to add a comparison test between old code vs new to ensure they return same results:
#1006
How is this documented