-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code sync to go-ethereum v1.13.14 #1152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into geth-v1.13.8
…m into geth-v1.13.8
This reverts commit 09d505bd5e906ac186643061437e665b116b5bf6.
ceyonur
reviewed
Aug 29, 2024
ceyonur
reviewed
Aug 29, 2024
ceyonur
reviewed
Aug 29, 2024
ceyonur
reviewed
Aug 29, 2024
This was referenced Aug 29, 2024
darioush
commented
Aug 29, 2024
ceyonur
previously approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ceyonur
previously approved these changes
Sep 2, 2024
ARR4N
previously approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for @ceyonur's latest push, which negates his approval
* avoid modifying the pointer * improve readability * prevent race in tail reading * improve repairTxIndexTail readability * use shared func
Force-Merging it since we merged an already approved PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Takes code from upstream
How this works
Takes code from upstream
How this was tested
[ ] CI
[ ] testnet
How is this documented
N/A