respect nolocals-setting #1159
Merged
respect nolocals-setting #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
previously approved these changes
Apr 22, 2024
PutraLaksmana
force-pushed
the
master
branch
3 times, most recently
from
343594f to
38b4a3f
Compare
darioush
previously approved these changes
Apr 23, 2024
darioush
approved these changes
Apr 23, 2024
ceyonur
approved these changes
Apr 23, 2024
|
Thanks again! |
|
No problem, happy to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Re-open PR, because my previous PR was broken due to not signed the commit.
How this works
Ensure that transactions added to the legacy pool are not treated as 'locals' if the global locals-management has been disabled.
Actually This PR from go-ethereum.
ethereum/go-ethereum#28435
This change makes the pool enforce the --txpool.pricelimit setting.
How this was tested
How is this documented