chore(all): simplify mocks generation #1413
Open
+78
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
changed the title
mock.gen.sh to use go generate commands
qdm12
force-pushed
the
qdm12/mock-gen-script
branch
from
3edebbc to
a37996e
Compare
ceyonur
reviewed
Dec 28, 2024
ceyonur
reviewed
Dec 30, 2024
ceyonur
reviewed
Dec 30, 2024
scripts/mock.gen.sh
Outdated
There was a problem hiding this comment.
do we have any sibling PR for avalanchego? This is a direct copy from avalanchego. I'd prefer to keep workflows in repos (coreth/subnet-evm/avalanchego) as similar as possible.
There was a problem hiding this comment.
Done in ava-labs/avalanchego#3628
I'm happy to wait for that PR to be discussed first and then merge the coreth and subnet-evm ones after.
There was a problem hiding this comment.
ava-labs/avalanchego#3628 merged, and I pushed a few commits here to make it as similar as possible 😉
qdm12
force-pushed
the
qdm12/mock-gen-script
branch
2 times, most recently
from
0c66511 to
b001446
Compare
- Add missing license headers - Localized mockgen commands in the package where they are needed - Less shell scripting needed - Remove unneeded `source` commands for constants.sh and versions.sh
(Note using source mode was compulsory due to CGO)
qdm12
force-pushed
the
qdm12/mock-gen-script
branch
from
0a20685 to
b466ccb
Compare
4 tasks
- requires a `tools.go` blank importing golang.org/x/mod/semver in order to have the `golang.org/x/mod` dependency satisfied for mockgen v0.4
- not used anywhere - different from avalanchego - does not work on windows' bash
qdm12
force-pushed
the
qdm12/mock-gen-script
branch
from
f7b7acb to
c2c5fb0
Compare
qdm12
changed the title
mock.gen.sh to use go generate commands
qdm12
changed the title
darioush
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
💁 Sibling PR for coreth so both repositories would look similar in this aspect
How this works
mocks_generate_test.gofile per package where mocks need to be generated, containing only//go:generatecommands for mock generation. Each command is relative to the current package directory//go:generate go run go.uber.org/mock/mockgento avoid requiring to pre-install mockgengocommand needed withgo generate -run "mockgen" ./...scripts/mocks.gen.shandscripts/mocks.mockgen.txtgit add --intent-to-add --allandgit diff --exit-code//go:generategeneration command, by removing all of them before re-generating themHow this was tested
CI passing (Golang unit tests > Mocks are up to date)
Need to be documented?
Yes in .github/CONTRIBUTING.md
Need to update RELEASES.md?
Not really