doesn't support ie11

[fred8617]

[fred8617]

i need to add these polyfills
import 'promise-polyfill/src/polyfill';
import 'unfetch/polyfill';
import 'abortcontroller-polyfill'
import 'url-search-params-polyfill';

[iamthesiz]

Will hop on this soon

[iamthesiz]

@Fled8617 It sounds like you might be on a Microsoft computer since you're using IE. It's kind of a pain to test IE on mac. Would greatly appreciate if you could submit a PR!

[iamthesiz]

I'm so excited I'm pretty sure I figured out a way to make this work.

[iamthesiz]

This might be fixed as of #196
As soon as I get a windows machine I'll test this, but until then, anyone who has a windows machine who might be able to confirm that this works, please comment on here so I can close this.

[Akswii]

It's not working for ie11 without the polyfills mentioned by @fred8617

[iamthesiz]

Mind submitting a PR @Akswii? I removed the Proxy so it shouldn't be too far off.

[Akswii]

Sorry, I don't have the time to look into it. Included the polyfills and got it working for my project. I appreciate your work @alex-cory 🙏

[iamthesiz]

@Akswii so you didn't need to add a polyfill for Object.entries?

[Akswii]

These are my current polyfills. I think a polyfill for Object.entries is included in one of the CRA polyfills.

[Akswii]

I double checked, Object.entries is not polyfilled with the react-app-polyfill, nor in any of the other packages as far as I can tell. Not sure if this is helpful or not @alex-cory

[iamthesiz]

@Akswii I'll make a branch, but could you pull down the branch and test it on your windows machine? Steps

git clone git@github.com:alex-cory/use-http.git
cd ./use-http
git checkout ie-support
yarn
yarn link
cd ..
create-react-app use-http-cra-app
cd ./use-http-cra-app
yarn
yarn link use-http
cd ../use-http
npm link ../use-http-cra-app/node_modules/react
npm link ../use-http-cra-app/node_modules/react-dom
cd ../use-http-cra-app
yarn start

Now just go into your use-http-cra-app/src/App.js and import use-http and test it in ie. I still need to make the ie-support branch so bare with me.