Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile warnings #9

Closed
dimitrilw opened this issue Sep 6, 2023 · 5 comments
Closed

compile warnings #9

dimitrilw opened this issue Sep 6, 2023 · 5 comments

Comments

@dimitrilw
Copy link
Contributor

As ref'd in #4 , the compiler has warnings re from_serde, into_serde, and a few other bits of code. It compiles, but I'd like to help get it to be warning-free. 🙂

@dimitrilw
Copy link
Contributor Author

Starting work on this.

@dimitrilw
Copy link
Contributor Author

dimitrilw commented Sep 7, 2023

All issues resolved except for one regarding debug_assertions in the Cargo.toml file.
image

The URL ref'd is:
https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies

That page explains how making a cfg(debug_assertions) doesn't work as anticipated. However, I am not 100% sure of the solution. Reading a bunch of posts on the issue; leaving this comment as a status update & reference for self.

Also, there are some warnings from clippy -- I'll start tweaking some of those too.

This process of refactoring is helping me to learn a lot. Thank you for allowing me to tinker with this repo.

@dimitrilw
Copy link
Contributor Author

One additional reminder to self:
There is this issue in the rust-webpack-template repo that ref's how this needs to be removed from the walk-through because it is misleading. But I still am not 100% sure what the "do this instead" path is. Will read more tomorrow.

@dimitrilw
Copy link
Contributor Author

dimitrilw commented Sep 7, 2023

Right after posting last comment, found this solution. But it is getting late, so will implement and send PR sometime tomorrow.

@dimitrilw
Copy link
Contributor Author

Ok, so I'm not entirely confident about implementing that solution. What I did appears to work, but I lack the familiarity with the build-n-deploy chain, so my confidence is lacking. I'm going to just PR with what I have and make a new ticket to remind me that I need to loop back to this issue after gaining more confidence with this repo, Rust, and the build process.

PR #12 closes most of this ticket & Issue #13 contains the remainder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant