Fixed console_error_panic_hook was not working #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason this is not merged? |
|
I'd like to chime in that this issue arises in following the beginner tutorials for 'Getting Started with WASM-Pack': A confusing issue for beginners which will no doubt discourage some new users from continuing on their quest to learn Rust. Please merge! 👍 |
Herohtar
approved these changes
Aug 31, 2021
There was a problem hiding this comment.
This needs to be merged. The use of non-existent conditional flags doesn't work and creates confusion for beginners who are following the tutorials that use this.
Edit: Technically, the comments are incorrect, as they imply that compiling in release vs debug will result in different behavior.
Herohtar
reviewed
Aug 31, 2021
Herohtar
reviewed
Aug 31, 2021
Herohtar
reviewed
Aug 31, 2021
Co-authored-by: Herohtar <herohtar@tuta.io>
Co-authored-by: Herohtar <herohtar@tuta.io>
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
console_error_panic_hook wasn't working properly, so I fixed Cargo.toml and src/lib.rs. ( #163 )