Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #13, fix "debug_assertions" in Cargo.toml #19

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

dimitrilw
Copy link
Contributor

Update Cargo.toml & src/lib.rs to reflect new guidance on implementing console_error_panic_hook. Changes were tested by:

  • npm run start
  • visual confirmation that dev site still has debug
  • npm run start:dist
  • visual confirmation that dist site does NOT have debug

Also:

  • add scripts to package.json
    • start:dist ...& ref in readme
    • clean ...& use it in other npm scripts
  • tidy build.rs & add comments
  • edit readme: npm run-script -> npm run
  • minor edit to test, to appease rust-analyzer
  • fix clippy warning in info.rs

Update Cargo.toml & src/lib.rs to reflect new guidance
on implementing console_error_panic_hook. Changes were
tested by:
  - npm run start
  - visual confirmation that dev site still has debug
  - npm run start:dist
  - visual confirmation that dist site does NOT have debug

Also:
- add scripts to package.json
  - start:dist ...& ref in readme
  - clean ...& use it in other npm scripts
- tidy build.rs & add comments
- edit readme: npm run-script -> npm run
- minor edit to test, to appease rust-analyzer
- fix clippy warning in info.rs
@dimitrilw
Copy link
Contributor Author

This PR closes issue #13 .

Copy link
Owner

@avacore1337 avacore1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@avacore1337 avacore1337 merged commit fb39eb5 into avacore1337:master Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants