Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update from pinned nightly rustc to unpinned stable #6

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

dimitrilw
Copy link
Contributor

  • switch rust-toolchain from pinned nightly to unpinned stable
  • remove nightly features from lib.rs
  • drain_filter: use vec.retain in place of nightly drain_filter feature
  • variant_count:
    • add variant_count crate to Cargo.toml
    • use variant_count::VariantCount in place of nightly feature

Also:

  • add to gitignore: vscode, trunk, MacOS
  • one typo fix: "Gallery" -> "Galley"
  • edited readme
    • add language notations to all code-blocks
    • consistent capitalization
    • a few typo fixes
    • update nvm version reference
    • other minor edits

Code compiles & passes tests.

- switch rust-toolchain from pinned nightly to unpinned stable
- remove nightly features from lib.rs
- drain_filter: use vec.retain in place of nightly drain_filter feature
- variant_count:
  - add variant_count crate to Cargo.toml
  - use variant_count::VariantCount in place of nightly feature

Also:
- add to gitignore: vscode, trunk, MacOS
- one typo fix: "Gallery" -> "Galley"
- edited readme
  - add language notations to all code-blocks
  - consistent capitalization
  - a few typo fixes
  - update nvm version reference
  - other minor edits

Code compiles & passes tests.
@dimitrilw dimitrilw mentioned this pull request Sep 6, 2023
Copy link
Owner

@avacore1337 avacore1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work. Glad to see that you got rid of all the nightly stuff

@avacore1337 avacore1337 merged commit 1013c20 into avacore1337:master Sep 6, 2023
@dimitrilw
Copy link
Contributor Author

Thank you. 😊

I'm really green with Rust, so I am 100% positive that I'll make a lot of mistakes along the way. For all I know, the changes I made might alter our benchmark performance -- I haven't done any benchmarking -- or some other negative side-effect. But it felt good to make those changes. 😄

Thank you for the positive feedback.

@dimitrilw dimitrilw deleted the issue/4-cannot-compile branch September 6, 2023 22:56
@avacore1337
Copy link
Owner

The rust code is crazy efficient (but only in release mode) so not too worried about performance there. I tried two different serialization strategies, but they were about the same. Only note though regarding performance is that if the code uses less than 1% of a core when the page is in the background you won't be throttled in the same way. Really important to make the game run well for something like an idle game.
Btw, if you really wanna give this a go and contribute, I'll try to write down something regarding some of my design choices, just so you have a reference.

@avacore1337
Copy link
Owner

You should also know I have a vue3 game also that I worked on after this:
https://github.com/avacore1337/tower-idle
Didn't get as far with content there though, but it is typescript which is good if you like that. It also has a newer toolchain for javascript since I started on that later.

@dimitrilw
Copy link
Contributor Author

I really appreciate all the thoughts you have. Thank you. Just eager to learn and improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants