Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer rename #15

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Add layer rename #15

merged 4 commits into from
Sep 26, 2022

Conversation

fso42
Copy link
Contributor

@fso42 fso42 commented Jul 4, 2022

  • Adds a script to rename layer based on comma-separated list of parameters
  • Script to get version
  • reorder runOperational
  • add a runCom1DFA script
  • automatic installation of avaframe on plugin installation
  • update script
  • add first pytests
  • add github action

@fso42 fso42 added the enhancement New feature or request label Jul 4, 2022
@fso42 fso42 self-assigned this Jul 4, 2022
@pep8speaks
Copy link

pep8speaks commented Jul 4, 2022

Hello @fso42! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 112:1: W293 blank line contains whitespace
Line 117:25: E251 unexpected spaces around keyword / parameter equals
Line 117:27: E251 unexpected spaces around keyword / parameter equals
Line 125:29: E251 unexpected spaces around keyword / parameter equals
Line 125:31: E251 unexpected spaces around keyword / parameter equals
Line 133:29: E251 unexpected spaces around keyword / parameter equals
Line 133:31: E251 unexpected spaces around keyword / parameter equals
Line 157:4: E114 indentation is not a multiple of four (comment)
Line 245:1: W293 blank line contains whitespace
Line 440:80: E501 line too long (157 > 79 characters)
Line 442:32: W291 trailing whitespace

Line 35:18: W291 trailing whitespace
Line 38:51: W291 trailing whitespace
Line 39:80: E501 line too long (113 > 79 characters)
Line 40:1: E302 expected 2 blank lines, found 1
Line 50:1: E305 expected 2 blank lines after class or function definition, found 1
Line 51:20: W291 trailing whitespace
Line 52:28: W291 trailing whitespace
Line 54:80: E501 line too long (85 > 79 characters)
Line 62:19: W291 trailing whitespace
Line 64:80: E501 line too long (105 > 79 characters)
Line 69:1: E402 module level import not at top of file
Line 70:1: E402 module level import not at top of file
Line 71:1: E402 module level import not at top of file
Line 72:1: E402 module level import not at top of file

Line 45:1: W293 blank line contains whitespace
Line 58:29: E251 unexpected spaces around keyword / parameter equals
Line 58:31: E251 unexpected spaces around keyword / parameter equals
Line 73:5: E303 too many blank lines (2)
Line 112:80: E501 line too long (89 > 79 characters)
Line 115:32: W291 trailing whitespace

Line 40:24: E131 continuation line unaligned for hanging indent
Line 41:24: E131 continuation line unaligned for hanging indent
Line 42:24: E131 continuation line unaligned for hanging indent
Line 43:24: E131 continuation line unaligned for hanging indent
Line 44:24: E131 continuation line unaligned for hanging indent
Line 61:5: E303 too many blank lines (2)
Line 75:80: E501 line too long (89 > 79 characters)
Line 80:5: E303 too many blank lines (2)
Line 87:9: E265 block comment should start with '# '
Line 88:80: E501 line too long (123 > 79 characters)
Line 94:80: E501 line too long (90 > 79 characters)
Line 106:33: E231 missing whitespace after ','
Line 106:45: E231 missing whitespace after ','
Line 108:17: E265 block comment should start with '# '
Line 121:59: E231 missing whitespace after ','
Line 145:5: E303 too many blank lines (2)

Line 39:1: E265 block comment should start with '# '
Line 39:80: E501 line too long (392 > 79 characters)
Line 42:1: E402 module level import not at top of file
Line 43:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 57:1: E402 module level import not at top of file
Line 58:1: E402 module level import not at top of file
Line 59:1: E402 module level import not at top of file
Line 65:80: E501 line too long (89 > 79 characters)
Line 79:5: E303 too many blank lines (2)
Line 94:1: W293 blank line contains whitespace
Line 99:25: E251 unexpected spaces around keyword / parameter equals
Line 99:27: E251 unexpected spaces around keyword / parameter equals
Line 107:29: E251 unexpected spaces around keyword / parameter equals
Line 107:31: E251 unexpected spaces around keyword / parameter equals
Line 115:29: E251 unexpected spaces around keyword / parameter equals
Line 115:31: E251 unexpected spaces around keyword / parameter equals
Line 124:4: E114 indentation is not a multiple of four (comment)
Line 136:9: E122 continuation line missing indentation or outdented
Line 161:80: E501 line too long (87 > 79 characters)
Line 166:80: E501 line too long (87 > 79 characters)
Line 180:9: E303 too many blank lines (2)
Line 187:9: E303 too many blank lines (2)
Line 212:1: W293 blank line contains whitespace
Line 250:9: E303 too many blank lines (2)
Line 257:1: W293 blank line contains whitespace
Line 268:9: E303 too many blank lines (2)
Line 283:13: E722 do not use bare 'except'
Line 293:9: E303 too many blank lines (2)
Line 311:47: E128 continuation line under-indented for visual indent
Line 312:47: E128 continuation line under-indented for visual indent
Line 323:9: E303 too many blank lines (2)
Line 329:9: E303 too many blank lines (2)
Line 376:80: E501 line too long (157 > 79 characters)
Line 378:32: W291 trailing whitespace

Comment last updated at 2022-09-06 17:54:28 UTC

@fso42 fso42 force-pushed the addLayerRename branch from 14919f2 to 515d6c0 Compare July 7, 2022 19:13
@codeclimate
Copy link

codeclimate bot commented Jul 7, 2022

Code Climate has analyzed commit c67563d and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3

View more on Code Climate.

  - Add com1DFA script, Rename and refactor operational
  - partly addresses #16
  - currently needs a QGis reboot after succesfull plugin installation
  - works on some windows OS...
@fso42 fso42 merged commit 2269fab into main Sep 26, 2022
@fso42 fso42 deleted the addLayerRename branch October 11, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants