Skip to content

Commit

Permalink
nmk/script: rm bad code
Browse files Browse the repository at this point in the history
I discovered that the scripts/ suffix is added to __nmk_dir despite
the fact it already contains it, ending in obviously wrong filenames
like scripts/nmk/scripts/scripts/msg.mk. As those files are non-existent,
make tried to recreate every .mk file, spawninga child to execute 'true'
command, like this (part of "make -dr" output):

> Considering target file '../scripts/nmk/scripts/scripts/include.mk'.
>  File '../scripts/nmk/scripts/scripts/include.mk' does not exist.
>  Finished prerequisites of target file
> '../scripts/nmk/scripts/scripts/include.mk'.
> Must remake target '../scripts/nmk/scripts/scripts/include.mk'.
> Putting child 0x564ec1768740 (../scripts/nmk/scripts/scripts/include.mk)
> PID 21633 on the chain.
> Live child 0x564ec1768740 (../scripts/nmk/scripts/scripts/include.mk)
> PID 21633
> Reaping winning child 0x564ec1768740 PID 21633
> Removing child 0x564ec1768740 PID 21633 from chain.

The fix was to remove the extra scripts/, but once I did it, I found
out problem #2: these targets, being defined in contents that is often
included in the beginning of Makefiles, hijacks the default make
target (the first one in the Makefile), breaking the usual and
expected make behavior, and forcing to use .DEFAULT_GOAL.

Finally, I don't know why these targets are there, i.e. what purpose
do they serve. Maybe it was done to exclude any implicit rules to
re-make those files, but there are no such rules as far as I can see.

So, in order to address problem #2, I have removed these targets.
I don't see any harm in doing that; let me know if it breaks anything.

Cc: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Signed-off-by: Pavel Emelyanov <xemul@virtuozzo.com>
  • Loading branch information
kolyshkin authored and xemul committed Oct 5, 2016
1 parent 9e2ce61 commit 25a1acd
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 14 deletions.
2 changes: 0 additions & 2 deletions scripts/nmk/scripts/build.mk
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,5 @@ mrproper: clean

#
# Footer.
$(__nmk_dir)scripts/build.mk:
@true
____nmk_defined__build = y
endif
2 changes: 0 additions & 2 deletions scripts/nmk/scripts/include.mk
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,5 @@ export build-as

#
# Footer.
$(__nmk_dir)scripts/include.mk:
@true
____nmk_defined__include = y
endif
2 changes: 0 additions & 2 deletions scripts/nmk/scripts/macro.mk
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,5 @@ endef

#
# Footer.
$(__nmk_dir)scripts/macro.mk:
@true
____nmk_defined__macro = y
endif
2 changes: 0 additions & 2 deletions scripts/nmk/scripts/main.mk
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,5 @@ $(eval $(call include-once,build.mk))

#
# Footer
$(__nmk_dir)scripts/main.mk:
@true
____nmk_defined__main = y
endif
2 changes: 0 additions & 2 deletions scripts/nmk/scripts/msg.mk
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,5 @@ map = $(foreach x,$2,$(call $1,$x)$(newline))

#
# Footer.
$(__nmk_dir)scripts/msg.mk:
@true
____nmk_defined__msg = y
endif #____nmk_defined__msg
2 changes: 0 additions & 2 deletions scripts/nmk/scripts/tools.mk
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,5 @@ export NM SH MAKE MKDIR AWK PERL PYTHON SH CSCOPE

#
# Footer.
$(__nmk_dir)scripts/tools.mk:
@true
____nmk_defined__tools = y
endif
2 changes: 0 additions & 2 deletions scripts/nmk/scripts/utils.mk
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,5 @@ cleanify = $(foreach o,$(sort $(call uniq,$(1))),$(o) $(o:.o=.d) $(o:.o=.i) $(o:

#
# Footer.
$(__nmk_dir)scripts/utils.mk:
@true
____nmk_defined__utils = y
endif

0 comments on commit 25a1acd

Please sign in to comment.