dump: fix Out-of-bounds write

CID 73355 (#1 of 1): Out-of-bounds write (OVERRUN) 6. overrun-local: Overrunning array loc_buf of 4096 bytes at byte offset 4096 using index ret (which evaluates to 4096).
avagin · Oct 31, 2014 · d0f15db · d0f15db
1 parent 69e1526
commit d0f15db
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cr-dump.c b/cr-dump.c
@@ -573,7 +573,7 @@ static int get_task_personality(pid_t pid, u32 *personality)
 	if (fd < 0)
 		goto err;
 
-	ret = read(fd, loc_buf, sizeof(loc_buf));
+	ret = read(fd, loc_buf, sizeof(loc_buf) - 1);
 	close(fd);
 
 	if (ret >= 0) {
@@ -756,7 +756,7 @@ static int parse_children(pid_t pid, pid_t **_c, int *_n)
 		if (fd < 0)
 			goto err;
 
-		len = read(fd, loc_buf, sizeof(loc_buf));
+		len = read(fd, loc_buf, sizeof(loc_buf) - 1);
 		close(fd);
 		if (len < 0)
 			goto err;