Marko/added benchmark for set code #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leouarz
approved these changes
Jul 18, 2023
kroos47
approved these changes
Jul 18, 2023
markopoloparadox
force-pushed
the
marko/added-benchmark-for-set-code
branch
2 times, most recently
from
95a1f19 to
c87c224
Compare
A change was made in how the scheduler calculates used weight. A scheduled tx with max_block_weight will fail with the following error: PermanentlyOverweight. The fix was to add a proper benchmark for set_code tx.
markopoloparadox
force-pushed
the
marko/added-benchmark-for-set-code
branch
from
c87c224 to
6554ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change was made in how the scheduler calculates used weight. A scheduled tx that uses
max_block_weightwill fail with the following error: PermanentlyOverweight.The fix was to add a proper benchmark for the
set_codetx.Closes: https://github.com/availproject/engineering/issues/100
Related Substrate Issue: paritytech/substrate#13192