Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated governance model #215

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

markopoloparadox
Copy link
Contributor

@markopoloparadox markopoloparadox commented Sep 4, 2023

Short Description

This PR adds a new pallet (Mandate) that allows the Technical Committee to execute privileged operations.

Long Description

The goal of this task was to implement a solution that would enable us to execute privileged operations through multiple simple-to-understand layers. So far, there were no complaints about how we use the sudo pallet, but understanding and reasoning with the democracy pallet proved to be a cognitive burden for most of us. Therefore, the decision was made to "replace" it with something simpler and easier to use.

In this case, the approach was to reuse the existing Technical Committee collective and pair it with a new custom pallet that extends the TC's abilities to execute privileged calls.

Usage

When creating a TC proposal, make sure that the outermost extrinsic is the mandate one from the Mandate pallet. This will ensure that the caller's origin will be changed to Root when the proposal is executed.

Technical Reasoning behind this change

Here is a list of other rejected potential implementations:

  • Custom Sudo Pallet: Forking the Sudo pallet just to add one small feature adds technical debt to our system.
  • Custom Technical Committee Pallet: Same as with the previous idea, forking just to make a small tweak isn't worth it.
  • Moving to Democracy v2: This would make our system even more complex and harder to reason with. Since we have no user base, there would be no benefits in having this kind of governance.

Artifacts

Documents will be created in order to explain how to use this new system.

@markopoloparadox markopoloparadox changed the base branch from main to develop September 4, 2023 11:28
@markopoloparadox markopoloparadox force-pushed the marko/update-governance-model branch 2 times, most recently from 2e1c26f to 85f8ed7 Compare September 4, 2023 11:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Patch coverage: 46.08% and project coverage change: -0.04% ⚠️

Comparison is base (5f83153) 50.67% compared to head (1183b96) 50.63%.

❗ Current head 1183b96 differs from pull request most recent head 8e04f1d. Consider uploading reports for the commit 8e04f1d to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #215      +/-   ##
===========================================
- Coverage    50.67%   50.63%   -0.04%     
===========================================
  Files           71       76       +5     
  Lines        10170    10401     +231     
===========================================
+ Hits          5154     5267     +113     
- Misses        5016     5134     +118     
Files Changed Coverage Δ
pallets/mandate/src/weights.rs 0.00% <0.00%> (ø)
runtime/src/lib.rs 18.01% <0.00%> (+0.03%) ⬆️
runtime/src/weights/pallet_mandate.rs 0.00% <0.00%> (ø)
pallets/mandate/src/mock.rs 14.00% <14.00%> (ø)
pallets/mandate/src/lib.rs 36.11% <36.11%> (ø)
pallets/mandate/src/tests.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markopoloparadox markopoloparadox changed the title Marko/update governance model Update governance model Sep 5, 2023
@markopoloparadox markopoloparadox changed the title Update governance model Updated governance model Sep 5, 2023
@markopoloparadox markopoloparadox force-pushed the marko/update-governance-model branch 2 times, most recently from 1183b96 to 8e04f1d Compare September 6, 2023 13:22
Copy link
Contributor

@Leouarz Leouarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems familiar, SUS

pallets/mandate/src/lib.rs Outdated Show resolved Hide resolved
@markopoloparadox markopoloparadox force-pushed the marko/update-governance-model branch from 8e04f1d to 628b88b Compare September 7, 2023 13:07
@markopoloparadox markopoloparadox force-pushed the marko/update-governance-model branch from 628b88b to 92f5bbf Compare September 7, 2023 13:17
@markopoloparadox markopoloparadox merged commit 5c739ef into develop Sep 7, 2023
@markopoloparadox markopoloparadox deleted the marko/update-governance-model branch September 7, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants