Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Require Maven Plugin - avaje-inject-maven-plugin #274

Merged
merged 13 commits into from
Feb 6, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Feb 5, 2023

First time I've ever made a maven plugin.

  • Use serviceloader in mvn plugin to create txt files containing the provided/autoprovided classes
  • update processor to read the text files and add to plugins/modules respectively (I think we can keep the existing service-loader stuff in there for stuff like Jsonb or other annotation processors that use plugins/modules).

Solves #272 #273

(Doesn't build in the pipeline because plugin isn't deployed, but it works on local)

@SentryMan
Copy link
Collaborator Author

Yeah, I'm good with this. I suck at naming things though, so feel free to change the names of things

@rbygrave rbygrave merged commit 2c97841 into avaje:master Feb 6, 2023
@rbygrave rbygrave added this to the 8.12 milestone Feb 6, 2023
@rbygrave rbygrave changed the title Auto-Require Maven Plugin Auto-Require Maven Plugin - avaje-inject-maven-plugin Feb 6, 2023
@rbygrave
Copy link
Contributor

rbygrave commented Feb 6, 2023

Great work. I have renamed the plugin to avaje-inject-maven-plugin.

My thought was to generate into target/classes something like target/classes/META-INFO/avaje-inject-provides.txt ... but I like what you've done here just putting into into target as it truely isn't needed in the final artifact etc.

I've released the io.avaje : avaje-inject-maven-plugin : 1.0 with a goal of provides
and released the rest as 8.12-RC4

Cheers, Rob.

@SentryMan SentryMan deleted the autorequire branch February 6, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants