Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Throwable Aspects #345

Merged
merged 1 commit into from
May 5, 2023
Merged

Fix Throwable Aspects #345

merged 1 commit into from
May 5, 2023

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented May 5, 2023 •
edited
Loading

Currently, proxying a method that throws Throwable causes a compilation error.

  • if thrown types are unchecked, don't write a superfluous catch clause
  • if method throws Throwable, rethrow it.

@rob-bygrave
Copy link
Contributor

Nice, I forgot about this case.

@rob-bygrave rob-bygrave added this to the 9.1 milestone May 5, 2023
@rob-bygrave rob-bygrave merged commit f2b2714 into avaje:master May 5, 2023
@SentryMan SentryMan deleted the fix-CheckedProxy branch May 5, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SentryMan SentryMan

Labels
None yet
Projects
None yet
Milestone
9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rob-bygrave