Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Factory Providers #517

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Fix Factory Providers #517

merged 5 commits into from
Mar 11, 2024

Conversation

SentryMan
Copy link
Collaborator

  • Fixes generated Modules not compiling in certain cases when using Provider in factory classes
  • Fixes DI classes not compiling with Providers of Generic Types
  • remove duplicate auto-provides in dependency metadata

@SentryMan SentryMan added the bug Something isn't working label Mar 9, 2024
@SentryMan SentryMan enabled auto-merge March 9, 2024 19:12
@SentryMan SentryMan self-assigned this Mar 9, 2024
@SentryMan SentryMan requested a review from rbygrave March 9, 2024 19:12
@SentryMan SentryMan modified the milestones: 9.q, 9.12 Mar 9, 2024
@SentryMan SentryMan mentioned this pull request Mar 10, 2024
Merged
@SentryMan SentryMan requested a review from rbygrave March 10, 2024 21:58
@SentryMan SentryMan removed this from the 9.12 milestone Mar 10, 2024
@rbygrave rbygrave disabled auto-merge March 11, 2024 10:31
@rbygrave rbygrave merged commit 1788d28 into avaje:master Mar 11, 2024
4 checks passed
@rbygrave rbygrave added this to the 9.12 milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbygrave rbygrave Awaiting requested review from rbygrave

Assignees

@SentryMan SentryMan

Labels
bug Something isn't working
Projects
None yet
Milestone
9.12
Development

Successfully merging this pull request may close these issues.
2 participants
@SentryMan @rbygrave