Make javax.annotation-api dependency optional #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norrisjeremy
force-pushed
the
optional-annotation-api
branch
2 times, most recently
from
b4a3f61 to
bbb3f11
Compare
…ax.annotation-api dependency optional.
norrisjeremy
force-pushed
the
optional-annotation-api
branch
from
bbb3f11 to
7d5a61d
Compare
|
Yes, I like this change. I think we can improve it a little by moving the |
|
Excellent, thanks! We make use of Guice in many internal projects and I'm interested in moving over to this as an alternative so that the injection is all handled at compile time. It's just that we don't make use of javax.annotation-api, so I was looking at how it could be left out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reflection to find javax.annotation.Priority, thus making the javax.annotation-api dependency optional.