Auto Generate Event Publishers #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
reviewed
May 2, 2024
inject-generator/src/main/java/io/avaje/inject/generator/TypeExtendsReader.java
Show resolved
Hide resolved
rbygrave
reviewed
May 2, 2024
| @@ -284,7 +284,7 @@ static String commonParent(String currentTop, String aPackage) { | |||
| static String getNamed(Element p) { | |||
| final NamedPrism named = NamedPrism.getInstanceOn(p); | |||
| if (named != null) { | |||
| return named.value(); | |||
| return named.value().replace("\"", "\\\""); | |||
There was a problem hiding this comment.
Why is this replace of quotes here?
There was a problem hiding this comment.
I'll revert this. If we are making some change here we want to be explicit in a separate PR and be clear what the change is and why.
There was a problem hiding this comment.
The reason is to bring it in line with the annotation qualifiers
rbygrave
reviewed
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes publishing events more CDI-like. The generator will now create a publisher class when it sees
Event<T>injected and a generated impl doesn't already exist.Event<T>dependency will create and wire a publisher that by default sends qualified events