Rename Property Plugin from PropertyRequiresPlugin to ConfigPropertyPlugin #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf9f166.
rob-bygrave
reviewed
Jun 7, 2024
rob-bygrave
changed the title
|
I'm pondering if we just go for a simple breaking change here. As in, likely very very few people have implemented this interface (it hasn't been around for a long time etc). So I think it might be acceptable and simple and less messy to just go with a simple rename and breaking change. Pondering ... |
It'll break every single one of the other avaje plugins that uses configuration if we do a clean break. Like the Jsonb Inject plugin for example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use it for more than the
@RequiresXannotations. Also I don't like the name.