Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jspecify Annotations #650

Merged
merged 16 commits into from
Jul 24, 2024
Merged

Support Jspecify Annotations #650

merged 16 commits into from
Jul 24, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Jul 18, 2024

It seems due to their nature as TYPE_USE annotations we had not been detecting them correctly.

  • replaces avaje lang with jspecify
  • fixes generator to handle type use nullable annotations
  • make jakarta inject static transitive (it's needed for compilation only)

Refer to https://jspecify.dev/docs/using#if-your-code-already-uses-jsr-305-annotations for differences we might see with this change

Also refer to https://jspecify.dev/docs/tool-conformance ... for more details on tooling support

resolves #649

@SentryMan SentryMan added this to the 10.2 milestone Jul 18, 2024
@SentryMan SentryMan self-assigned this Jul 18, 2024
@SentryMan SentryMan added the enhancement New feature or request label Jul 18, 2024
@SentryMan SentryMan requested a review from rbygrave July 18, 2024 12:21
@SentryMan SentryMan requested a review from rob-bygrave July 20, 2024 03:18
@rbygrave rbygrave merged commit 68be46b into avaje:master Jul 24, 2024
7 checks passed
@SentryMan SentryMan deleted the jspecify branch December 24, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Avaje Lang with Jspecify?
3 participants