Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change - Remove support for Deprecated Interfaces (please upgrade dependencies) #670

Merged
merged 13 commits into from
Nov 24, 2024

Conversation

SentryMan
Copy link
Collaborator

The generator already prevents code from generating with the old interfaces, this seals the deal.

@SentryMan SentryMan requested a review from rbygrave August 26, 2024 03:13
@SentryMan SentryMan self-assigned this Aug 26, 2024
@SentryMan SentryMan added this to the 10.4 milestone Aug 26, 2024
@SentryMan SentryMan enabled auto-merge August 26, 2024 12:57
@rbygrave
Copy link
Contributor

The generator already prevents code from

BUT currently older plugin dependencies do still work. This PR means that they will no longer work ... with the implication that it FORCES people to update their dependencies of the various plugins. As such it is breaking change.

Is that not the case?

@SentryMan SentryMan removed this from the 10.4 milestone Aug 27, 2024
@SentryMan
Copy link
Collaborator Author

We can give more time then if you don't think people have upgraded their dependencies, I made the PR because I recently migrated all my job's avaje plugins to the new interfaces

@rbygrave rbygrave changed the title Remove Deprecated Interfaces Breaking change - Remove support for Deprecated Interfaces (please upgrade dependencies) Aug 28, 2024
@rbygrave
Copy link
Contributor

We can give more time then if you don't think people have upgraded their dependencies

Yes, I think we need to give people more time.

As I see it the ideal ... is for breaking changes to be in their own release with no other changes (no other bug fixes, no other PRs). I think that helps anyone who is trying to follow what is going on when a given release ONLY contains breaking changes - there are no other changes included that bury/hide the important detail that the release will be a breaking change for some apps.

In addition, ideally the title of the PR is clear and obvious that it's a breaking change. I've adjusted this title to hopefully be more clear in terms that it could breaking some apps and what people are expected to do (update the dependencies).

The saying I have is "It does not hurt to be bloody obvious". People are busy, they only scan release notes at best ... the PR and Issue titles are super important and we should try and make them "bloody obvious" if we can etc.

@rob-bygrave rob-bygrave added this to the 11.0 milestone Sep 5, 2024
@SentryMan SentryMan merged commit 396cb19 into avaje:master Nov 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants