Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internals] Make generation easier to debug #753

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

SentryMan
Copy link
Collaborator

Modifies the Append Class to have a toString implementation using stringbuilder. In this way, we can easily debug file formatting/generation issues in a debugger

@SentryMan SentryMan added the enhancement New feature or request label Jan 5, 2025
@SentryMan SentryMan added this to the 11.1 milestone Jan 5, 2025
@SentryMan SentryMan self-assigned this Jan 5, 2025
@SentryMan SentryMan requested a review from rbygrave January 5, 2025 02:25
@SentryMan SentryMan enabled auto-merge January 5, 2025 02:25
@SentryMan SentryMan disabled auto-merge January 6, 2025 22:06
@SentryMan SentryMan enabled auto-merge (squash) January 6, 2025 22:07
@rbygrave rbygrave removed this from the 11.1 milestone Jan 6, 2025
@rbygrave
Copy link
Contributor

rbygrave commented Jan 7, 2025

For debugging I tend to generate comments into the source code. I'm kinda thinking that this potentially will add a decent amount of extra memory consumption/churn for everyone running the annotation processor [not just us]? Hmmm.

@SentryMan
Copy link
Collaborator Author

SentryMan commented Jan 7, 2025

For debugging I tend to generate comments into the source code.

I like to debug the annotation processor with my eclipse while it's running using the InjectProcessorTest.

will add a decent amount of extra memory consumption

I'll make it a flag that's turned off by default then

@SentryMan SentryMan merged commit ed57918 into avaje:master Jan 7, 2025
7 checks passed
@rbygrave rbygrave added this to the 11.1 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants