-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate AVA docs to zh_CN #17
Conversation
d6c9a52
to
bdbfa85
Compare
32a848a
to
ebdbd20
Compare
@zhaozhiming Thank you! :) Do you know anyone that could review this? |
OK,I invite some Chinese people to review this. |
The translation quality is pretty good, didn't see any obvious problem. My only quibble is that latin letters and Chinese characters should be separated by a space. While this rule is not written down anywhere, this issue is something of a religious issue. Designers & typography people would strongly recommend a space, while the "commoners" don't care either way. (As far as I know, nobody recommend AGAINST adding a space) It's enough of a problem that people have written a Chrome plugin to do exactly this. |
@zhaozhiming you can probably use this script to add the spaces "use strict";
const XRegExp = require("XRegExp");
const str = "Mocha要求你使用隐式全局变量比如`describe`和`it`作为其默认接口";
const cn_latin_regex = XRegExp('(\\p{Latin})(\\p{Han})');
console.log(cn_latin_regex.test(str)) ;
const str2 = XRegExp.replace(str, cn_latin_regex,(m, m1, m2) => {
return `${m1} ${m2}`;
});
console.log(str2); |
@sindresorhus I reviewed the translation, and think it acceptable. |
@hayeah Great solution! I use it to replace the text, but have a little change with @ruanyf Thank you for review. You're so nice. 👍 @sindresorhus Review is done, please continue, thank you. |
@zhaozhiming Awesome ! |
___ | ||
**备注** | ||
|
||
这是[code-of-coduct.md](https://github.com/sindresorhus/ava/blob/master/code-of-coduct.md)的简体中文翻译。这个[链接](https://github.com/sindresorhus/ava/compare/master...zhaozhiming:master)用来查看本翻译与AVA 的master 分支是否有差别(如果你没有看到`code-of-coduct.md`发生变化,那就意味着这份翻译文档是最新的)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad link replace:
https://github.com/sindresorhus/ava/compare/master...zhaozhiming:master
by:
https://github.com/sindresorhus/ava/compare/89767ec3b6174e59d37faaadb50cfa3c0d58bda6...master#diff-d3030a18b089fdb1fbfabf6e75e4aef0
___ | ||
**备注** | ||
|
||
这是[typescript.md](https://github.com/sindresorhus/ava/blob/master/docs/recipes/typescript.md)的简体中文翻译。这个[链接](https://github.com/sindresorhus/ava/compare/master...zhaozhiming:master)用来查看本翻译与AVA 的master 分支是否有差别(如果你没有看到`typescript.md`发生变化,那就意味着这份翻译文档是最新的)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad link replace:
https://github.com/sindresorhus/ava/compare/master...zhaozhiming:master
By:
https://github.com/sindresorhus/ava/compare/8e2f3dca177a4283ad882596d3c1425cabb998ef...master#diff-60cce07a584082115d230f2e3d571ad6
@zhaozhiming Except my remarks for the links, It's beautiful work! Thank you |
@forresst Thank you for your great work, your review is so carefully. I change the remark now, please review continue, thanks. The reason of I used the link like By the way, could you teach me how to generate the branch compare link? That I can generate them next time. Thank you. |
@zhaozhiming No worries, I understand.
An example for readme.md file, the link is, in your translated file :
|
@forresst OK, thank you very much. 👍 |
LGTM for me. |
@sindresorhus Is there any other problems? |
@zhaozhiming Thank you! This is great. Added you to the repo. Feel free to just commit and push changes directly ;) And thanks for reviewing @forresst :) |
@zhaozhiming @forresst Huge thanks, guys! |
HI,
I like AVA and I want to translate the docs of AVA to Chinese, which will help more Chinese people study and use AVA.
@ALL I have translated all the docs already, please review, thank you very much.
todo list: