Make t.log() behave like console.log()
#1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kugtong33
force-pushed
the
assert-log-revamp
branch
from
85ec4ba to
1214212
Compare
novemberborn
requested changes
Jan 24, 2018
There was a problem hiding this comment.
console.log() uses util.format() underneath, which supports placeholder tokens. I couldn't quite find a maintained & ready module that would let us support the same tokens. Perhaps we can leave that as a follow-up.
lib/assert.js
Outdated
| @@ -122,8 +122,15 @@ function wrapAssertions(callbacks) { | |||
| } | |||
| }, | |||
|
|
|||
| log(text) { | |||
| log(this, text); | |||
| log(...args) { | |||
There was a problem hiding this comment.
For the next few months we're still targeting Node.js 4, which doesn't support rest parameters. You'll have to use plain old arguments instead.
kugtong33
force-pushed
the
assert-log-revamp
branch
from
20890be to
0548a36
Compare
lib/assert.js
Outdated
| args.forEach((value, index) => { | ||
| args[index] = typeof value === 'string' ? | ||
| value : concordance.format(value, concordanceOptions); | ||
| }); |
There was a problem hiding this comment.
Since you're really mapping args anyway this would be better as:
const args = Array.from(arguments, value => {
// ...
});There was a problem hiding this comment.
that makes sense! I was trying to find a better way :)
novemberborn
approved these changes
Jan 25, 2018
sindresorhus
changed the title
t.log() behave like console.log()
|
Thanks @kugtong33! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1635
Use concordance to format all arguments except string arguments as the existing test will fail and I find it awkward this way. Update test to cater
t.log()andt.log(n1, n2, n3, ...).