Fail when tests executed without cli #191
Conversation
| var runner = new Runner(); | ||
|
|
||
| // check if the test is being run without AVA cli | ||
| var isForked = typeof process.send === 'function'; |
There was a problem hiding this comment.
Probably clearer to just check if the file was executed directly: require.main === module
There was a problem hiding this comment.
But index.js is never required directly.
There was a problem hiding this comment.
No matter if I use node test.js or ava test.js, require.main === module is always false.
vadimdemedes
force-pushed
the
run-without-ava-error
branch
from
b229dfb to
8972428
Compare
| var path = relative('.', process.argv[1]); | ||
|
|
||
| log.write(); | ||
| log.error('Test files must be run with the AVA CLI::\n\n $ ava ' + path + '\n'); |
vadimdemedes
force-pushed
the
run-without-ava-error
branch
from
8972428 to
956002e
Compare
| var path = relative('.', process.argv[1]); | ||
|
|
||
| log.write(); | ||
| log.error('Test files must be run with the AVA CLI:\n\n $ ava ' + path + '\n'); |
There was a problem hiding this comment.
and maybe add chalk.dim('$') and chalk.cyan to the command? just to be fancy.
There was a problem hiding this comment.
chalk.grey.dim('$') + ' ' + chalk.cyan('ava') + ' ' + path?
There was a problem hiding this comment.
I was thinking the full command:
chalk.dim('$') + ' ' + chalk.cyan('ava ' + path)
To indicate what they can copy-paste.
There was a problem hiding this comment.
Perfect. Just ava in cyan looks better, but this is clearer.
vadimdemedes
force-pushed
the
run-without-ava-error
branch
from
956002e to
41b4746
Compare
Fail when tests executed without cli
|
@vdemedes being productive today :D |
|
|
This PR fixes #179.
Here's the output: