-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make watch mode dependency tracking work with custom require hooks #2088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @lo1tuma! Some comments below.
I’ve noticed that the
sources
patterns inava.config.js
must not start with a leading./
otherwiseava-files
doesn’t recognize the files as source files.
That seems odd. You should still be able to specify patterns within directories that are then treated as source files.
Specifying directories works, but as I said only without leading Directory structure:
When I specify |
Hi @novemberborn, great work with #2103. I’ve updated this PR to only address #2049. |
Thanks @lo1tuma! |
Fixes: #2049
I’ve tested these fixes with one of my projects where sources and test files are written in typescript. I use
@babel/register
and@babel/typescript
instead oftsc
.BTW: I’ve noticed that the
sources
patterns inava.config.js
must not start with a leading./
otherwiseava-files
doesn’t recognize the files as source files.