Further helper selection improvements #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t treated as test files
novemberborn
force-pushed
the
disregard-changes-from-unknown-files
branch
2 times, most recently
from
8ca00a2
to
4f42295
Compare
isSource() calls isTest(), so it's more efficient to classify whether a file is either in a single call.
… helpers or sources Since ignore patterns are no longer passed to Chokidar, if a file is not a test, helper or source, then tests do not need to be re-run.
novemberborn
force-pushed
the
disregard-changes-from-unknown-files
branch
from
a9c6af7
to
a1d8943
Compare
novemberborn
force-pushed
the
disregard-changes-from-unknown-files
branch
from
a1d8943
to
597822f
Compare
novemberborn
force-pushed
the
disregard-changes-from-unknown-files
branch
from
5413206
to
d8dafce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ignore patterns are no longer passed to Chokidar, if a file is not a test, helper or source, then tests do not need to be re-run.
Support helper glob configuration (fixes #2105).
I've also made the necessary documentation changes.