Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add test suite for es2015 polyfills #266

Closed

Conversation

jamestalmage
Copy link
Contributor

Based on the conversation in #263, I'm starting to work up a test suite that
actually excercises ALL the ES2015 features, so we know what we are missing.

This is a rough start. If someone wants to help divide and conquer, just ping me on
Gitter to discuss.

@vadimdemedes
Copy link
Contributor

Oooh, I am not sure about this one. Our test suite will grow tremendously, if we test every ES6 feature. That's definitely up to babel project to test these. We just need to fix our babel issues and get it right.

@sindresorhus
Copy link
Member

Good idea! But I think this would be better as a separate project. Something like a ES2015 tester project that both we and Babel could consume.

@sindresorhus
Copy link
Member

There's actually https://github.com/kangax/compat-table which already does this. Should probably just reuse that one instead.

@vadimdemedes
Copy link
Contributor

@sindresorhus +1

@jamiebuilds
Copy link
Contributor

@sindresorhus https://github.com/kangax/compat-table is a bad test suite for ES6 features, it's very shallow. https://github.com/tc39/test262 is better

@sindresorhus
Copy link
Member

I think we should put this on hold until we have upgraded to Babel 6.

@sindresorhus
Copy link
Member

But I think this would be better as a separate project. Something like a ES2015 tester project that both we and Babel could consume.

Closing for the above reason. @jamestalmage If you're no longer interested in doing this and think it's still relevant, can you open an issue?

@jamestalmage jamestalmage deleted the es2015-static-polyfills branch April 6, 2016 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants