recipe: when to use t.plan #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamestalmage
force-pushed
the
when-to-use-plan
branch
2 times, most recently
from
5e4e0bf to
654bc1c
Compare
| @@ -0,0 +1,124 @@ | |||
| # Using t.plan in AVA | |||
|
Very good! Can you add it to the Recipe section in the readme? |
|
|
||
| ```js | ||
| test(t => { | ||
| t.plan(1); |
jamestalmage
force-pushed
the
when-to-use-plan
branch
from
654bc1c to
9045f2a
Compare
|
I'm not understanding the last two comments. |
|
nevermind - GH wasn't showing them inlined. I see what you are saying now. |
jamestalmage
force-pushed
the
when-to-use-plan
branch
from
82d18ad to
36960f0
Compare
|
Very nice James! |
I think I made all the changes you asked for. Make sure I didn't get ⬆️ backwards though. |
|
just saw one more typo |
jamestalmage
force-pushed
the
when-to-use-plan
branch
from
36960f0 to
cd80387
Compare
|
fixed. |
|
LGTM |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: jfmengels/mocha-vs-ava-performance#1 (comment)
Reviewers: @sindresorhus @vdemedes @SamVerschueren @kevva, et. all.
I'm only pretending to be an authority on the topic, critiques welcome.