rename t.ok() to t.truthy() and t.notOk() to t.falsy()
#716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @uiureo, @sotojuan and @kasperlewau to be potential reviewers |
kentcdodds
force-pushed
the
pr/ok-to-truthy
branch
from
342881f to
fed5812
Compare
| }); | ||
|
|
||
| test.serial(t => { | ||
| const a = 'bar'; | ||
|
|
||
| t.ok(a === 'foo', 'with message'); | ||
| t.truthy(a === 'foo', 'with message'); |
There was a problem hiding this comment.
Actually, these should just be t.true.
|
Responded to all comments :-) |
|
LGTM |
| }); | ||
| ``` | ||
|
|
||
| Will output: | ||
|
|
||
| ``` | ||
| t.ok(a.test(b) || b === c) | ||
| t.true(a.test(b) || b === c) |
There was a problem hiding this comment.
The power-assert example right under this should be moved a bit to the right. The lines do not point to what is described.
added 2 commits
April 5, 2016 09:49
sindresorhus
changed the title
ok to truthy and notOk to falsyt.ok() to t.truthy() and t.notOk() to t.falsy()
sindresorhus
added a commit
to avajs/atom-ava
that referenced
this pull request
Apr 5, 2016
sindresorhus
added a commit
to avajs/sublime-ava
that referenced
this pull request
Apr 5, 2016
|
Seems you need to update some test assertions too. |
|
I guess this is why we have Travis :-) |
|
Updated. Should be good to go now :D |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty confident that this is ready to go.