Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: rerunnable test stats #759

Closed

Conversation

jamestalmage
Copy link
Contributor

This creates a TestStats object we can use to track various stats for the current run (and previous runs when in watch mode).

Critically, it's smart about tallying pass, fail, skip, and todo counts even with complicated rerun patterns.

Born from this comment.

I haven't integrated it with anything yet. Just submitting for feedback.

@sindresorhus
Copy link
Member

Hard to give feedback without seeing how it's going to be used, but I like the idea in general.

Are we still doing this?

Maybe @novemberborn can share some thoughts on it.

@jamestalmage
Copy link
Contributor Author

This is kinda what RunStatus has become. We definitely don't need the reset ability, because we create a new RunStatus for each pass.

@jamestalmage
Copy link
Contributor Author

OK, so apparently it was designed with RunStatus in mind. I will take another look this weekend, and close if I don't think it's worth doing anymore.

@novemberborn
Copy link
Member

Would be nice to draw up a desired architecture for how the API, CLI & Watcher interact with each other and how to abstract the shared pieces, including the logging. There's a fair amount of coupling at the moment, through methods that exist just to enable a slight variation of the behavior.

@jamestalmage
Copy link
Contributor Author

Yes. That sounds like a good plan. Not a big fan of writing code to design documents, but as long as we don't take them as gospel, and just use it to agree on some basic goals.

@novemberborn
Copy link
Member

Not a big fan of writing code to design documents, but as long as we don't take them as gospel, and just use it to agree on some basic goals.

Indeed. Helps clarify direction.

@jamestalmage
Copy link
Contributor Author

I've opened #865, which basically just documents what we have now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants