Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: refactor watcher #766

Merged
merged 7 commits into from
May 20, 2016
Merged

Conversation

jamestalmage
Copy link
Contributor

So far I've only moved some of the path processing stuff into AvaFiles.

@novemberborn
Copy link
Member

@jamestalmage sorry haven't had a chance yet to look at this.

@jamestalmage
Copy link
Contributor Author

@novemberborn - bump!

I'd like to push forward with this. There are a number of TODO comments in this PR with your name on it (quite literally). I'd like your feedback on how we should proceed.


var debug = sinon.spy();
function proxyWalker(opts) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walker?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giphy 10

@novemberborn
Copy link
Member

@jamestalmage very cool!

@@ -1,9 +1,12 @@
var fs = require('fs');
var path = require('path');
var nodePath = require('path');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same as the above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - it's from combining the two codebases. nodePath was used in watcher, because he used a path variable inside methods. I can clean that up.

@sindresorhus
Copy link
Member

What's left for this to land?

@jamestalmage
Copy link
Contributor Author

Assuming the rest of the AppVeyor runs pass, this should be mergeable.

@jamestalmage jamestalmage merged commit fdd7970 into avajs:master May 20, 2016
@jamestalmage jamestalmage deleted the refactor-watcher branch May 20, 2016 05:10
@novemberborn
Copy link
Member

The correct question is, what about require('foo-bar.json') or require('foo-bar.coffee').

Does this mean smart walking won't work with .coffee?

I assume you meant ./foo-bar.coffee? But that should be picked up as a dependency, matchable against watched sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants