Skip to content

Commit

Permalink
Update airbnb base config and simplify custom rules
Browse files Browse the repository at this point in the history
- Remove comma-dangle rule because of reasons stated by airbnb
- Require strict because of reasons stated by airbnb
- Do not allow importing devDependencies because a separate eslint config file should be used for tests (airbnb/javascript#959 (comment))
  • Loading branch information
maoberlehner committed May 1, 2017
1 parent 14ba61b commit 619a538
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 14 deletions.
12 changes: 0 additions & 12 deletions packages/eslint-config/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,6 @@ module.exports = {
sourceType: `module`,
},
rules: {
'comma-dangle': [2, {
arrays: `always-multiline`,
objects: `always-multiline`,
imports: `always-multiline`,
exports: `always-multiline`,
functions: `never`,
}],
strict: 2,
quotes: [2, `backtick`, { avoidEscape: true }],
'import/no-extraneous-dependencies': [2, {
devDependencies: true,
optionalDependencies: true,
}],
},
};
4 changes: 2 additions & 2 deletions packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"javascript",
"styleguide"
],
"version": "1.0.0",
"version": "0.1.0",
"author": "Markus Oberlehner",
"homepage": "https://github.com/modularis/eslint-config-modularis",
"license": "MIT",
Expand All @@ -20,7 +20,7 @@
"url": "https://github.com/avalanchesass/avalanche/issues"
},
"dependencies": {
"eslint-config-airbnb-base": "^10.0.1"
"eslint-config-airbnb-base": "^11.1.3"
},
"engines": {
"node": ">= 6"
Expand Down

0 comments on commit 619a538

Please sign in to comment.