Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to display full filenames on the media object edit page #5049

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Feb 3, 2023

Resolves #5025

This PR adds hover text and an expand/show less option to filenames on the Media Object edit page.

The expand/show less option only renders on filenames that get truncated.
Screenshot_20230203_121734

Screenshot_20230203_121750

Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 💯
I have one comment on the CSS override

app/assets/stylesheets/avalon.scss Outdated Show resolved Hide resolved
Co-authored-by: Dananji Withana <dwithana@iu.edu>
@masaball masaball requested a review from Dananji February 3, 2023 20:16
Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Dananji Dananji merged commit c4e3003 into develop Feb 3, 2023
@Dananji Dananji deleted the edit_page_full_filename branch February 3, 2023 21:37
This was referenced Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants