Override ActiveFedora and HydraAccessControls to ensure AccessControl… #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… objects are marked dirty and autosave so they get indexed properly
masaball
approved these changes
Mar 31, 2023
There was a problem hiding this comment.
This looks good as far as I can tell. I've been trying to brainstorm some additional test cases/approaches, but only thing that comes to mind is that Emily's video was testing adding an IP address so maybe specifically testing the IP address update path would catch the bug.
But even if this is not a production only bug, Emily did say in her video that which items index the change was variable so I'm really not sure about how to get consistently failing tests pre-fix...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… objects are marked dirty and autosave so they get indexed properly
I added some tests but was not able to get any of them to fail prior to the changes in this PR. It is possible that the issue is only present in a production environment.