Turn off feeding caption tracks into embedded player #5688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Captions are currently contained in the HLS manifest and these are parsed by VideoJS. We do not need to manually provide text tracks to the embedded player because of this. This commit also includes a change to the filtering of captions for the embedded player for if/when we reenable manually providing them so that issues will not arise for implementers who run the caption file migration.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captions are currently contained in the HLS manifest and these are parsed by VideoJS. We do not need to manually provide text tracks to the embedded player because of this. This commit also includes a change to the filtering of captions for the embedded player for if/when we reenable manually providing them so that issues will not arise for implementers who run the caption file migration.