Delete supplemental files when parent object is deleted #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Aug 23, 2024
There was a problem hiding this comment.
This works for requests to delete MasterFiles but there are also requests to delete MediaObjects. (See
avalon/app/models/media_object.rb
Line 190 in 37cfbea
Do you think it would work to move it into the MasterFile model?
masaball
force-pushed
the
child_file_delete
branch
from
7dda5d3
to
fe40545
Compare
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
cjcolvar
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #5871
Do not merge until after 7.8 release.