Remove mediainfo gem, replace with ffprobe call #5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Active encode still uses MediaInfo for the time being so we need to make sure that variables are still being set up properly. This commit also adds safe navigation or other conditionals to prevent errors when MediaInfo or FFmpeg are not defined properly in Settings.yml.
masaball
force-pushed
the
remove_mediainfo
branch
from
1b321a0
to
efe41de
Compare
cjcolvar
reviewed
Aug 26, 2024
|
FWIW I looked at the ffprobe analyzer service in ActiveStorage which looks really similar to https://github.com/rails/rails/blob/main/activestorage/lib/active_storage/analyzer/video_analyzer.rb |
cjcolvar
reviewed
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #5762