Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use auto-submitting form to workaround omniauth2 requirement for only POST requests to auth endpoints #6007

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Use auto-submitting form to workaround omniauth2 requirement for only POST requests to auth endpoints #6007

merged 1 commit into from
Sep 4, 2024

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Aug 26, 2024 •
edited
Loading

Necessary for setting up omniauth strategies other than identity (local password).

Part of #6005

@cjcolvar cjcolvar marked this pull request as ready for review September 4, 2024 19:52
masaball
masaball approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell

@cjcolvar cjcolvar merged commit 49ee610 into develop Sep 4, 2024
2 checks passed
@cjcolvar cjcolvar deleted the omniauth_2_devise branch September 4, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcolvar @masaball