Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide default required metadata in IIIF Manifest #6030

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Provide default required metadata in IIIF Manifest #6030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/iiif_manifest_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def description
end

def to_s
media_object.title
media_object.title || media_object.id
end

def manifest_metadata
Expand Down Expand Up @@ -180,7 +180,7 @@ def display_lending_period(media_object)

def iiif_metadata_fields
fields = [
metadata_field('Title', media_object.title),
metadata_field('Title', media_object.title, media_object.id),
metadata_field('Date', combined_display_date(media_object), 'Not provided'),
metadata_field('Main contributor', media_object.creator),
metadata_field('Summary', display_summary(media_object)),
Expand Down
13 changes: 13 additions & 0 deletions spec/models/iiif_manifest_presenter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@
let(:master_file) { FactoryBot.build(:master_file, media_object: media_object) }
let(:presenter) { described_class.new(media_object: media_object, master_files: [master_file]) }

context 'to_s' do
it "returns the media object's title" do
expect(presenter.to_s).to eq media_object.title
end

context 'when media object is missing title' do
it "returns the media object's id" do
allow(media_object).to receive(:title).and_return(nil)
expect(presenter.to_s).to eq media_object.id
end
end
end

context 'homepage' do
subject { presenter.homepage.first }

Expand Down