Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent bad encode status from breaking encode record pages #6068

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Prevent bad encode status from breaking encode record pages #6068

merged 1 commit into from
Oct 8, 2024

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Oct 7, 2024

Screenshot_20241007_150959

Related issue: #6018

cjcolvar
cjcolvar approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good job catching all of these odd cases!

@masaball masaball merged commit 18e3388 into develop Oct 8, 2024
2 checks passed
@masaball masaball deleted the nil_encodes branch October 8, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaball @cjcolvar